Skip to content

Commit

Permalink
fix: remove index on application create call in beta composer #122
Browse files Browse the repository at this point in the history
  • Loading branch information
@uhudo
uhudo authored Nov 1, 2024
1 parent a7d4682 commit e4a6435
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/algokit_utils/beta/composer.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,6 @@ def _build_app_call(
sdk_params = {
"sender": params.sender,
"sp": suggested_params,
"index": params.app_id or 0,
"on_complete": params.on_complete or algosdk.transaction.OnComplete.NoOpOC,
"approval_program": params.approval_program,
"clear_program": params.clear_program,
Expand Down Expand Up @@ -484,6 +483,7 @@ def _build_app_call(

txn = algosdk.transaction.ApplicationCreateTxn(**sdk_params) # type: ignore[no-untyped-call]
else:
sdk_params["index"] = params.app_id
txn = algosdk.transaction.ApplicationCallTxn(**sdk_params) # type: ignore[assignment,no-untyped-call]

return self._common_txn_build_step(params, txn, suggested_params)
Expand Down

1 comment on commit e4a6435

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit_utils
   _debugging.py140795%20, 41, 76, 80, 89, 129, 157
   _ensure_funded.py69199%99
   _transfer.py67396%13, 76–77
   account.py851385%14–17, 61–65, 96, 109, 136, 139, 183
   application_client.py5287785%59–60, 167, 172, 201, 313, 318–319, 321, 323, 788, 803, 821–824, 914, 954, 966, 979, 1021, 1081–1087, 1091–1096, 1098, 1134, 1141, 1254, 1284, 1298, 1336–1338, 1340, 1350–1407, 1418–1423, 1443–1446
   application_specification.py971189%92, 94, 193–202, 206
   asset.py79594%9, 27–30
   common.py13192%13
   config.py511865%38–39, 50, 55, 60, 64–69, 100–109
   deploy.py4632595%30–33, 168, 172–173, 190, 246, 362–363, 418, 429–437, 454–457, 467, 475, 668–669, 693
   dispenser_api.py821285%112–113, 117–120, 155–157, 176–178
   logic_error.py39295%8, 31
   models.py131695%45, 50–52, 61–62
   network_clients.py63395%93–94, 125
src/algokit_utils/beta
   account_manager.py551475%39–40, 64, 123–130, 183–187, 198–200
   algorand_client.py1011585%111–112, 121–122, 143–145, 154–155, 224, 259, 274, 290, 303, 319
   client_manager.py371073%40, 61–63, 68–70, 75–78
   composer.py3217278%335–336, 339–340, 343–344, 347–348, 355–356, 359–360, 389, 391, 393, 396, 399, 404, 407, 411, 414, 456–489, 494–505, 510–516, 521–529, 549–562, 566, 590, 593–610, 618, 643, 659–660, 662–663, 665–666, 668–669, 671–672, 678–682
TOTAL243529588% 

Tests Skipped Failures Errors Time
204 0 💤 0 ❌ 0 🔥 2m 55s ⏱️

Please sign in to comment.