-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: initial documentation for beta release #128
Conversation
|
||
## `Account` and Transaction Signing | ||
|
||
The core type that holds information about a signer/sender pair for a transaction in Python is the `Account` class, which represents both the signing capability and sender address in one object. This is different from the TypeScript implementation which uses `TransactionSignerAccount` interface that combines an `algosdk.TransactionSigner` with a sender address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should mirror the TS utils here? Might be worth a chat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, will introduce a further overhaul to have TransactionSignerAccount introduced as a protocol, would require a bigger chunk of changes so will address in a separate PR as part of last batch of improvements in preparation for pypi release. Will keep the issue unresolved for now
algorand = AlgorandClient.default_local_net() | ||
# Point to TestNet using AlgoNode free tier | ||
algorand = AlgorandClient.test_net() | ||
# Point to MainNet using AlgoNode free tier | ||
algorand = AlgorandClient.main_net() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we changed local_net
to localnet
, this would apply to main_net
and test_net
etc.
- `accounts: list[str] | None` - Any account addresses to add to the accounts array | ||
- `foreign_apps: list[int] | None` - The ID of any apps to load to the foreign apps array | ||
- `foreign_assets: list[int] | None` - The ID of any assets to load to the foreign assets array | ||
- `boxes: list[BoxReference | BoxIdentifier] | None` - Any boxes to load to the boxes array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous comment about matching the TS naming.
…to prerelease/docs
Renaming network related namings from *_net to *net
Co-authored-by: Neil Campbell <neil.campbell@makerx.com.au>
Proposed Changes
The changes focus on improving documentation clarity and providing guidance for migrating from v2 to v3 of AlgoKit Utils Python.