fix: app creation via methodCall (#274)

docs/code/classes/types_composer.default.md

@@ -467,7 +467,7 @@ The built atomic transaction composer and the transactions
 
 #### Defined in
 
-[src/types/composer.ts:711](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L711)
+[src/types/composer.ts:724](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L724)
 
 ___
 
@@ -488,7 +488,7 @@ ___
 
 #### Defined in
 
-[src/types/composer.ts:590](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L590)
+[src/types/composer.ts:603](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L603)
 
 ___
 
@@ -509,7 +509,7 @@ ___
 
 #### Defined in
 
-[src/types/composer.ts:539](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L539)
+[src/types/composer.ts:552](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L552)
 
 ___
 
@@ -530,7 +530,7 @@ ___
 
 #### Defined in
 
-[src/types/composer.ts:519](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L519)
+[src/types/composer.ts:532](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L532)
 
 ___
 
@@ -551,7 +551,7 @@ ___
 
 #### Defined in
 
-[src/types/composer.ts:554](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L554)
+[src/types/composer.ts:567](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L567)
 
 ___
 
@@ -572,7 +572,7 @@ ___
 
 #### Defined in
 
-[src/types/composer.ts:564](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L564)
+[src/types/composer.ts:577](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L577)
 
 ___
 
@@ -593,7 +593,7 @@ ___
 
 #### Defined in
 
-[src/types/composer.ts:576](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L576)
+[src/types/composer.ts:589](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L589)
 
 ___
 
@@ -634,7 +634,7 @@ ___
 
 #### Defined in
 
-[src/types/composer.ts:630](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L630)
+[src/types/composer.ts:643](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L643)
 
 ___
 
@@ -676,7 +676,7 @@ ___
 
 #### Defined in
 
-[src/types/composer.ts:507](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L507)
+[src/types/composer.ts:520](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L520)
 
 ___
 
@@ -697,7 +697,7 @@ ___
 
 #### Defined in
 
-[src/types/composer.ts:648](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L648)
+[src/types/composer.ts:661](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L661)
 
 ___
 
@@ -743,7 +743,7 @@ The execution result
 
 #### Defined in
 
-[src/types/composer.ts:753](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L753)
+[src/types/composer.ts:766](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L766)
 
 ___
 
@@ -762,4 +762,4 @@ The newly built atomic transaction composer and the transactions
 
 #### Defined in
 
-[src/types/composer.ts:743](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L743)
+[src/types/composer.ts:756](https://github.com/algorandfoundation/algokit-utils-ts/blob/main/src/types/composer.ts#L756)

src/types/algorand-client.spec.ts

@@ -1,11 +1,19 @@
 /* eslint-disable no-console */
-import { TestContractClient } from '../../tests/example-contracts/client/TestContractClient'
+import algosdk from 'algosdk'
+import { APP_SPEC, TestContractClient } from '../../tests/example-contracts/client/TestContractClient'
 import * as algokit from '../index'
 import { algorandFixture } from '../testing'
 import { TransactionSignerAccount } from './account'
 import AlgorandClient from './algorand-client'
 import { MethodCallParams } from './composer'
 
+async function compileProgram(algorand: AlgorandClient, b64Teal: string) {
+ const teal = new Uint8Array(Buffer.from(b64Teal, 'base64'))
+ const result = await algorand.client.algod.compile(teal).do()
+
+ return new Uint8Array(Buffer.from(result.result, 'base64'))
+}
+
 describe('AlgorandClient', () => {
  let algorand: AlgorandClient
  let alice: TransactionSignerAccount
@@ -196,4 +204,16 @@ describe('AlgorandClient', () => {
  })
  expect(await algod.accountAssetInformation(alice.addr, Number(assetId)).do()).toBeDefined()
  })
+
+ test('methodCall create', async () => {
+ const contract = new algosdk.ABIContract(APP_SPEC.contract)
+
+ await algorand.send.methodCall({
+ sender: alice.addr,
+ appId: 0n,
+ method: contract.getMethodByName('createApplication'),
+ approvalProgram: await compileProgram(algorand, APP_SPEC.source.approval),
+ clearProgram: await compileProgram(algorand, APP_SPEC.source.clear),
+ })
+ })
 })

src/types/composer.ts

@@ -484,10 +484,23 @@ export default class AlgokitComposer {
 
  const methodAtc = new algosdk.AtomicTransactionComposer()
 
+ const appID = Number(params.appId || 0)
  methodAtc.addMethodCall({
- ...params,
- appID: Number(params.appId || 0),
+ appID,
+ sender: params.sender,
  suggestedParams,
+ onComplete: params.onComplete,
+ appAccounts: params.accountReferences,
+ appForeignApps: params.appReferences?.map((x) => Number(x)),
+ appForeignAssets: params.assetReferences?.map((x) => Number(x)),
+ approvalProgram: params.approvalProgram,
+ clearProgram: params.clearProgram,
+ extraPages: params.extraPages,
+ numLocalInts: params.schema?.localUints || (appID === 0 ? 0 : undefined),
+ numLocalByteSlices: params.schema?.localByteSlices || (appID === 0 ? 0 : undefined),
+ numGlobalInts: params.schema?.globalUints || (appID === 0 ? 0 : undefined),
+ numGlobalByteSlices: params.schema?.globalByteSlices || (appID === 0 ? 0 : undefined),
+ method: params.method,
  signer: params.signer ? ('signer' in params.signer ? params.signer.signer : params.signer) : this.getSigner(params.sender),
  methodArgs: methodArgs,
  // note, lease, and rekeyTo are set in the common build step