Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: double addr in resource population #242

Closed
wants to merge 1 commit into from
Closed

fix: double addr in resource population #242

wants to merge 1 commit into from

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Mar 12, 2024

Proposed Changes

  • Resource population would erroneously try to put the same address in the account array twice if that address was used for an assetHolding. This would result in a false error regarding not having enough space to populate resources

@joe-p
Copy link
Contributor Author

joe-p commented Mar 12, 2024

FYI there seems to be degredation in GitHub PRs right now. The branch is up to date but this PR is not so its missing the docs (which I squashed on the branch as seen here main...fix/resource_pop_double_addr)

@robdmoore robdmoore closed this Mar 13, 2024
@robdmoore
Copy link
Contributor

Weird, I tried closing and reopening and it won't let me reopen

@robdmoore robdmoore mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdmoore robdmoore robdmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-p @robdmoore