Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: removing temporary workaround with fixed 2.2 algosdk for simulate fallback #96

Merged
merged 2 commits into from
Jul 21, 2023
Merged

refactor: removing temporary workaround with fixed 2.2 algosdk for simulate fallback #96

merged 2 commits into from
Jul 21, 2023

Conversation

aorumbayev
Copy link
Contributor

@aorumbayev aorumbayev commented Jul 21, 2023 •
edited
Loading

Proposed changes

  • Removing temporary workaround with pinned algosdk 2.2 version used for simulate fallback during call invocation in AppClient
  • Fixed a side effect that can cause cases when calling abi methods in generated ts client with txn as input params fail due to mismatch of atc instance trying to encode Transaction objects made in >2.2.x version of algo sdk. (Bug report by @joe-p)

Further notes

  • Extra smoke test needed once this becomes a prerelease

@aorumbayev aorumbayev merged commit a3b34b5 into main Jul 21, 2023
2 checks passed
@aorumbayev aorumbayev deleted the removing-algosdk-2.2 branch July 21, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdmoore robdmoore robdmoore approved these changes

@daniel-makerx daniel-makerx Awaiting requested review from daniel-makerx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aorumbayev @robdmoore