Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): optional extra footer item #327

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

urtho
Copy link
Member

@urtho urtho commented Nov 22, 2024

Description

This PR adds an optional footer item with URL based on the build time env vars.

Details

Two new env vars :

  • VITE_FOOTER_EXTRA_ITEM - item label
  • VITE_FOOTER_EXTRA_ITEM_HREF - item URL

When VITE_FOOTER_EXTRA_ITEM env var is defined at build time, an extra item is added to the dashboard footer.

Example:

VITE_FOOTER_EXTRA_ITEM="Nodely DISCLAIMER"
VITE_FOOTER_EXTRA_ITEM_HREF=https://nodely.io/docs/public/reti/

pbennett and others added 2 commits November 21, 2024 14:38
…documentation location.

Updated the README.md to include a new documentation section.
The section provides a link to the online documentation and describes the syncing process with the docs/gitbook branch.
@urtho urtho requested a review from drichar as a code owner November 22, 2024 14:41
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reti ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 6:51pm

drichar
drichar previously approved these changes Nov 22, 2024
Copy link
Collaborator

@drichar drichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Instead of appending the disclaimer, let's put it in place of the outdated "TxnLab/reti" link (see comment).

ui/src/components/Footer.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@drichar drichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@drichar
Copy link
Collaborator

drichar commented Nov 22, 2024

Just change the target branch for the PR to dev, then when it's time for a new release dev is merged into main with a version bump.

@urtho urtho changed the base branch from main to dev November 22, 2024 19:24
@urtho urtho requested a review from pbennett as a code owner November 22, 2024 19:24
@pbennett pbennett merged commit f2c12fe into algorandfoundation:dev Nov 22, 2024
4 checks passed
@urtho urtho deleted the nodely/footer-item-env branch November 22, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants