Python3 monte carlo #148
Python3 monte carlo #148
Conversation
Butt4cak3
added
the
Implementation
|
I'm afraid you're a bit late. People are already working on Monte Carlo in Python over in #144. If you want, you can join the conversation and suggest some changes. Sorry for that! We weren't really prepared for the sudden rush of contributors. We're of course still thankful for your contribution. The timing was just a bit unlucky. Feel free to add a code example for another algorithm and check that there's not an open pull request dealing with it already. |
june128
added
Duplicate
|
Hi @RonPeleg, the person that sent the PR that came right before you is unresponsive, so we are switching to you. Are you up for it? I only have a few points for you to change. |
|
One more thing: you need to include your code into |
| @@ -5,3 +5,4 @@ Gathros | |||
| Jeremie Gillet (- Jie -) | |||
| Salim Khatib | |||
| Hitesh C | |||
| name | |||
There was a problem hiding this comment.
It's probably better if you put in your actual name :)
| return x ** 2 + y ** 2 < r ** 2 | ||
|
|
||
|
|
||
| def monte_carlo(n, r): |
There was a problem hiding this comment.
We have moved away from using r as a free parameter in monte_carlo, so you can remove it here, and call in_circle(x, y, 1) instead of in_circle(x, y, r). Another, clean alternative is to change def in_circle(x, y, r): to def in_circle(x, y, r = 1): and then just use it as in_circle(x, y).
| if in_circle(x, y, r): | ||
| points_in_circle += 1 | ||
|
|
||
| pi_estimate = 4.0 * points_in_circle / (n * r ** 2) |
There was a problem hiding this comment.
Then in this line you don't need r ** 2 anymore.
| pi_erro = 100*(math.pi - pi_estimate)/math.pi | ||
| return pi_estimate, pi_erro | ||
|
|
||
| print(monte_carlo(10000000, 0.5)) |
There was a problem hiding this comment.
The last thing is, it's best if you have a main() function that prints something like "The estimated value of pi is..." and "the Error is...". The error should be calculated in main() as well because it's not part of the algorithm.
jiegillet
added
Implementation
|
Actually, you know what? I have this suspicion that @RonPeleg is already gone. So let's give them another day (it has been 5 at this time) and then move on if we get no answer. |
|
OK. We have other PRs for the same algorithm. |
|
I'd honestly just take the branch of the inactive PR that everyone was working on and create a new PR based on that. |
clean code for monte carlo algo