-
-
Notifications
You must be signed in to change notification settings - Fork 359
Racket implementation for Bubble Sort #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome, @Unlambder! There's not much I can say other than thanks for the contribution. You thought of pretty much everything. I'm not sure whether we have a Racket developer who can properly review your code, so give it a few days time. If we can't find anyone, we'll probably just merge it anyway. |
I read the code and, without prior knowledge of Racket, I think I made sense out of it, thanks for contributing. Could you add some kind of main function with a test of the algorithm on a small list? This way someone without knowledge of the syntax (as myself) could run it and play around. |
I made a try it online link, will that be enough? (If it is I'll just add it to the bottom of the visible code) |
Is it hard or un-Racketty to include the test in the file? (I'm asking in full candor) |
@Unlambder With the code submitted to the AAA, we want it to be possible to run locally on a machine. Therefor a main function kind of thing is useful since it sometimes calls different functions, etc. So I would suggest using a main function here as well. |
I created an issue for the discussion about the use of code-run-websites. I heavily support it. |
I added an executable snippet to the file. To answer your question @jiegillet it's not that I find it un-Racketty or anything to include tests in the file, it's just that I didn't really know how i should include them. |
Thanks for your last commit. I was able to run it on an online interpreter. Good enough for me. I'll merge the PR everyone is satisfied. |
Added a racket implementation of Bubble Sort.
The bubbleSort function can be accessed by writing "(require "bubbleSort.rkt")" with the relevant file in the current directory.
I also put my name in Contributors.md since it seemed to be required.