-
-
Notifications
You must be signed in to change notification settings - Fork 360
switch over to clang-format style #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can upload a .clang-format if you want, as well
also, fix Tree.cpp
Yeah, I guess it makes sense to change the style to something that is easy to maintain. I assume that this is done simply with the |
I have no idea. I don't know what .editorconfig is. |
It looks like .editorconfig has been entirely replaced by clang-format in the C++ community; similarly with rustfmt in the Rust community. Is it possible, for languages with formatting tools, to use those instead? |
That seems reasonable and should probably be mentioned in PR #59 |
A .clang-format file in the repo sounds like a good idea to me. I briefly read up on clang-format and saw that it's not only used for C++. What I did not find, however, is a way to place multiple .clang-format files for multiple languages in the same repository. Is there a way to do this? Would it even make sense or should we just use it for C++ and leave it at that? |
@Butt4cak3 I have zero opinion on non-C++ languages. That'd be up to the contributes for those languages. |
Oh, it's actually quite trivial.
so basically, if people of other languages want to use .clang-format, they can. @leios I don't think so; it's trivial to add support for other languages once they agree how they're going to format them, and this is blocking me on some other things I'd like to do. |
Yep! although I'll add a clang-format to the base directory. |
@leios please merge |
Alright. Gathros said he didn't mind the format change earlier, so it should be fine. |
I can add a .clang-format as well;