-
-
Notifications
You must be signed in to change notification settings - Fork 359
Monte Carlo Scratch Implementation #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monte Carlo Scratch Implementation #619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @c252 handle the actual review, just wanted to throw my 2 cents in. I'm fine with the code as-is.
If it is alright with you then I am fine with it. |
Maybe I can add |
Sure, that would work for now at least... And we have the scratchblocks code, so it's no where near as hard to modify as before. |
BTW, after I looked up the source code of scratch3, I realized the random generator can generate |
Oh, nice! So we don't need the arbitrarily large value anymore! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change. Thanks for the work on this PR!
- Add `radius` parameter - Directly generate doubles
14f8041
to
3e66435
Compare
There seems to be a lot of empty space under the |
I think somewhere in the program you might need to set the radius variable to 1 because in scratch3 the variables will default to 0. |
About |
I figured that was how you did it, but my worry was that if someone else copied this scratch code and ran it the radius would be 0 and it wouldn't work properly. (It's not a very big deal) |
About |
What I thought is if they see the comment, they should know they should set |
This looks good to Me! |
The |
Can't view again? Umm... I'll fix it if I have time... |
This PR is ready to go, except that the svg image has whitespace under it when rendering the Algorithm Archive. I can try to take a look at it in more detail if you cannot figure this out. There are some issues with css + svg. We can relatively easily convert everything to png and it will work fine; however, there might be a way to get this to work with a viewbox This was tested in Firefox and chromium on linux. |
Yeah, that is confirmed. Setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for fixing the cropping issue!
No description provided.