Skip to content

Add computus in C++ #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2020
Merged

Conversation

VincentZalzal
Copy link
Contributor

No description provided.

@berquist berquist added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label May 24, 2020
Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one request. For your two conditionals, can you add braces? Everything else looks good.

@VincentZalzal
Copy link
Contributor Author

Sure, no problem. I also added braces to the for-loop, for consistency. Would be nice to have a style guide somewhere for that kind of stuff. At least, clang-format handles a big chunk of that already.

Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes. We do have https://github.com/algorithm-archivists/algorithm-archive/blob/master/.clang-format, but like EditorConfig, there's sometimes a barrier of helping people get those set up properly with their environment.

As for style guides, C++ in particular was a bit contentious is the past, but generally speaking, the start of one is in https://github.com/algorithm-archivists/algorithm-archive/wiki/Code-style-guide. If you have suggestions, feel free to add them to #481.

Otherwise, approved!

@berquist berquist merged commit 4313e7e into algorithm-archivists:master May 24, 2020
@VincentZalzal
Copy link
Contributor Author

Sorry, my comment was unclear. I meant, at least you provide a clang-format config, which handles much style issues already, which is nice. I used it before submitting :)

@VincentZalzal VincentZalzal deleted the computus-cpp branch May 24, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants