Added Bogosort in Coconut #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berquist
requested changes
Jul 19, 2020
| for x, y in zip(a, a[1:]): | ||
| if x > y: | ||
| return False | ||
| return True |
There was a problem hiding this comment.
I would like to see a full FP solution rather than the Python solution. Folding the map comes to mind.
There was a problem hiding this comment.
why reduce when you already have all built-in?
Thanks for the more functional style requests!
berquist
added
the
Implementation
berquist
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, it's not really interesting, but I used more idiomatic Python for the
is_sortedfunction, iterating over the array and a shifted copy of the array, rather than over the indices.That's basically all I did from the Python implementation, except removing the
mainfunction, that serves little purpose in Python.