Fixed infinite loop issue in "euclidean_example.py" #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saleniece
approved these changes
Sep 3, 2020
Amaras
approved these changes
Sep 3, 2020
|
I enjoyed working on this issue. Also, can I add my name to the CONTRIBUTORS.md file now or do I have to wait for the PR to get merged? |
|
You can do it now, at the risk of having to resolve conflicts later if another branch gets merged, or do it later, but that would mean opening another PR |
|
I guess I will do it after it gets merged. Thanks. |
|
It looks like you need to change the line numbers in the |
|
@leios Hi, I have changed the line numbers in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #740