Skip to content

Rust version of IFS #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 28, 2021
Merged

Conversation

Liikt
Copy link

@Liikt Liikt commented Sep 30, 2020

I created the IFS in rust. It has to pull in the rand crate though. (Why doesn't rust have a rand lib in the standard lib anyway?)

@Liikt Liikt added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Sep 30, 2020
@leios
Copy link
Member

leios commented Oct 12, 2020

firstly, code looks good and runs fine. I am happy to merge it; however, I still have some lingering questions about running code like this from the AAA (#691). Should we maybe include the Cargo.toml with this? I know it's different than what we did with the other implementations for Rust, but I feel it would help!

@ntindle
Copy link
Member

ntindle commented Aug 28, 2021

[lang: rust]

@github-actions github-actions bot added the lang: rust Rust programming language label Aug 28, 2021
Copy link
Contributor

@stormofice stormofice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Overall this code looks good to me and seems to be very similar in concept to #896, which makes me want to approve this.
However I don't feel completely confident in reviewing Rust code, so a second opinion would be good.

I did include a small suggestion to standardize the output file's name, as seen in #961.

Copy link
Contributor

@ShadowMitia ShadowMitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes are needed to make this compile and remove some tiny warnings.
Otherwise I think it's good!

@Amaras
Copy link
Member

Amaras commented Dec 8, 2021

Hello @Liikt!
Since this has an external dependency (namely the rand crate), we now require a cargo.toml file for compilation (for automated compilation).
Could you please add the file in if you have some time?

Julian and others added 2 commits December 28, 2021 01:26
Co-authored-by: Dimitri Belopopsky <ShadowMitia@users.noreply.github.com>
Co-authored-by: stormofice <58337328+stormofice@users.noreply.github.com>
@Liikt
Copy link
Author

Liikt commented Dec 28, 2021

I have commited the suggested changes and a cargo toml

Copy link
Contributor

@ShadowMitia ShadowMitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@ShadowMitia ShadowMitia merged commit 51936d7 into algorithm-archivists:main Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest The label for all Hacktoberfest related things! hacktoberfest-accepted Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) lang: rust Rust programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants