-
-
Notifications
You must be signed in to change notification settings - Fork 359
Rust version of IFS #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust version of IFS #755
Conversation
firstly, code looks good and runs fine. I am happy to merge it; however, I still have some lingering questions about running code like this from the AAA (#691). Should we maybe include the Cargo.toml with this? I know it's different than what we did with the other implementations for Rust, but I feel it would help! |
[lang: rust] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Overall this code looks good to me and seems to be very similar in concept to #896, which makes me want to approve this.
However I don't feel completely confident in reviewing Rust code, so a second opinion would be good.
I did include a small suggestion to standardize the output file's name, as seen in #961.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of changes are needed to make this compile and remove some tiny warnings.
Otherwise I think it's good!
Hello @Liikt! |
Co-authored-by: Dimitri Belopopsky <ShadowMitia@users.noreply.github.com> Co-authored-by: stormofice <58337328+stormofice@users.noreply.github.com>
I have commited the suggested changes and a cargo toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
I created the IFS in rust. It has to pull in the rand crate though. (Why doesn't rust have a rand lib in the standard lib anyway?)