Skip to content

Make Euclid's algorithm in Nim more idiomatic #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2020
Merged

Make Euclid's algorithm in Nim more idiomatic #784

merged 1 commit into from
Nov 11, 2020

Conversation

berquist
Copy link
Member

  • func signifies that the procedures have no side effects: they are proper functions.
  • Use the implicit result return variable instead of explicit returns.
  • when isMainModule behaves the same way as if __name__ == "__main__" in Python.

@berquist berquist added Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! hacktoberfest-accepted labels Oct 28, 2020
@leios
Copy link
Member

leios commented Nov 4, 2020

@c252 Any way you can review the nim prs?

On my end, I am happy to merge them!

@c252
Copy link
Member

c252 commented Nov 4, 2020

Yeah this looks good to me.

leios
leios approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c252 says it looks good, so I'm on board!

@leios leios merged commit 5a6ebd0 into algorithm-archivists:master Nov 11, 2020
@berquist berquist deleted the nim-cleanup-euclid branch September 6, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leios leios leios approved these changes

Assignees
No one assigned
Labels
Hacktoberfest The label for all Hacktoberfest related things! hacktoberfest-accepted Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berquist @leios @c252