-
-
Notifications
You must be signed in to change notification settings - Fork 359
Added Cooley-Tukey in Common Lisp #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Cooley-Tukey in Common Lisp #786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An excellent submission, glad that you're interested @0xJonas. I've been the single person implementing the algorithms in Common Lisp up until now and I'm happy to see another Lisper in the archive.
One last thing, It would maybe help to put some extra comments throughout the code. The archive tries to provide good code examples for people learning programming languages and it can be helpful to provide some extra information.
The code is still fine as is, however, and if you correct the small formatting problems, it should be ready for merging.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick response, I assumed that you were going to do points for sentences, so I left some suggestions for the comments.
I've rechecked some of the other common lisp code and how comments and docstrings are handled is all over the place (even when one person made all of them), so don't worry about it. Just make sure it's consistent within the file.
Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>
Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>
Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>
Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>
Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>
Co-authored-by: Trashtalk217 <trashtalk217@gmail.com>
Oops, I forgot to update a line number after the previous commit. |
Sorry for the late confirmation, I misunderstood something. But it's good to merge! |
Essentially a port of my Scala PR (#746) which appears to be stuck in review.