Added Iterated function system in PowerShell #895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormofice
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Hi, thanks for the contribution!
The code looks clean and the resulting image is similar to the ones generated by the other implementations.
However it should be noted that a PowerShell version greater or equals than 7.0 is required to run this script.
I don't know if this is the same for the existing PowerShell implementations, but it is something to keep in mind for the automatic compilation/interpretation with SConscript.
[The devcontainer seems to always install the latest PowerShell (currently 7.2.0.1), so it should not be a problem there]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try the code on systems other than Windows, you can run the code here: https://code.labstack.com/powershell
It will generate a file that you can download afterwards.