-
-
Notifications
You must be signed in to change notification settings - Fork 359
Change SCons output structure #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change SCons output structure #963
Conversation
This seems to work to me. Not one of the people who originally weighed in though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great! I would have loved to see this with "edge cases" like the code for the convolution chapter to make sure it works, but I think it is fine as is.
I'll wait a second to merge it in case there are more informed opinions
I've tested nested chapters with dummy files and it works as far as I can tell. I've got no idea what will happen if there's a code directory inside another, so we should avoid that (although I don't know how that would happen). This also doesn't replicate the structure inside the individual language directories, so if that matters it will need an SConscript file. |
The PR for #954
Currently:
scons rust