Skip to content

Incorrect type for LogTracer functions? #6

@MarkKoz

Description

@MarkKoz
Member

LogTracer.set()'s parameter has a type of string but the print functions use any. All functions seem to have the same general purpose: to log the argument given Well, which type is it then? Is set() really meant to have a different type than the rest?

Activity

64json

64json commented on Jul 28, 2019

@64json
Member

I designed that way so that LogTracer.set() directly sets the string value that will be displayed whereas the print functions convert the value to string and then append it to the displayed value. However, I agree that LogTracer.set() should also convert any value to string first before setting it in order to not confuse users. You can make LogTracer.set() in tracers.py have any parameter. I'll fix it in tracers.js and algorithm-visualizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @MarkKoz@64json

        Issue actions

          Incorrect type for LogTracer functions? · Issue #6 · algorithm-visualizer/tracers.js