Skip to content

Convert Modeldata to Dict #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Convert Modeldata to Dict #12

merged 1 commit into from
Nov 18, 2021

Conversation

zeryx
Copy link
Contributor

@zeryx zeryx commented Nov 16, 2021

This PR removes the user_data and system_data objects of ModelData, and instead converts the modelData object itself into a dictionary type! This dramatically simplifies interactions in load functions, and allows for easy use by algorithm developers to store data that can later be used at runtime, without having to create a separate object, or reference a special member or method.

Now if you want to export everything what was recorded in userspace, you simply need to call the .data() method, which returns a dict containing the key/value pairs stored.

@zeryx zeryx requested a review from aslisabanci November 16, 2021 18:14
@zeryx zeryx self-assigned this Nov 16, 2021
Copy link
Contributor

@aslisabanci aslisabanci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this simplification :) nothing stood out for me, so 👍

@zeryx zeryx merged commit 9ddd7f8 into develop Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants