ALGO-62 Integrated mlops agent #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lemonez
reviewed
Jun 14, 2022
| @@ -91,8 +94,18 @@ def write_to_pipe(self, payload, pprint=print): | |||
| def process_local(self, local_payload, pprint): | |||
| result = self.apply(local_payload) | |||
| self.write_to_pipe(result, pprint=pprint) | |||
|
|
|||
| def mlops_init(self): | |||
| mlops_token = os.environ.get("DATAROBOT_MLOPS_API_TOKEN", None) | |||
There was a problem hiding this comment.
Is there a reason you aren't using the same env var as the monitoring agent itself? This might make things simpler, unless you specifically don't want them to be the same. That would be just MLOPS_API_TOKEN.
There was a problem hiding this comment.
Yeah, in the event that there are other MLOPS API tokens from different orgs; wanting to be very clear about what this token is used for so it's not confused with any algorithmia token
aslisabanci
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the mlops agent client-side interface logic to the ADK. Exposing a
mlopsvariable to the.init()function.requires the
environment_validatorin langpacks to validate.algorithmiaio/langpacks#228 check this out to test
to test:
./tools/environment_validator.py -g python3 -s python39 -d java11 -d mlops-agent -t dependency -n python39-mlopswill need to add an environment variable to the template file to validate.