Skip to content

removal of api-client utilization for algo.publish #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

zeryx
Copy link
Contributor

@zeryx zeryx commented Oct 15, 2021

As part of our efforts to remove segments of the api-client from the python mgmt api; and as a request by a customer, we've hardcoded the post request required for the algo publish workflow. This has been tested and should allow the customer to proceed with other work.

To test, compile an existing algorithm, and run algo.publish(version_info={"version_type": "minor", "release_notes": "automatically deployed by CI"}, settings={"royalty_microcredits": 0}, details={"label": "CICD"})

Also included ADK Model Manifest and changes to load function workflow from the ADK in this PR

@zeryx zeryx self-assigned this Oct 15, 2021
aslisabanci
aslisabanci previously approved these changes Oct 15, 2021
Copy link
Contributor

@aslisabanci aslisabanci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel dirty doing this😛 - but okay, LGTM. thanks james!

@aslisabanci aslisabanci merged commit 056ef1c into develop Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants