Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require space after Atx heading hashes #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DivineDominion
Copy link

Since Sp is defined as Spacechar*, right now a line like:

#foo

Will be treated as a heading, which is uncommon enough for the CommonMark spec to specify as a mistake :) -- In practical terms, this makes editors with hashtags at the beginning of a line behave weirdly.

Since `Sp` is defined as `Spacechar*`, right now a line like:

    #foo

Will be treated as a heading, which is uncommon enough for the CommonMark spec to specify as a mistake :) -- In practical terms, this makes editors with hashtags at the beginning of a line behave weirdly.
@@ -55,7 +55,7 @@ Plain = Inlines

AtxInline = !Newline !(Sp '#'* Sp Newline) Inline

AtxStart = < ( "######" | "#####" | "####" | "###" | "##" | "#" ) >
AtxStart = < ( "######" | "#####" | "####" | "###" | "##" | "#" ) Spacechar >
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding Spacechar here will make the level of heading incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants