Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add shims for browser and change the sts expire time of example … #316

Merged
merged 3 commits into from
Dec 21, 2017
Merged

fix: add shims for browser and change the sts expire time of example … #316

merged 3 commits into from
Dec 21, 2017

Conversation

PeterRao
Copy link
Collaborator

  1. add shims for browser
  2. change the default sts expire time fo the example project

@codecov-io
Copy link

codecov-io commented Nov 14, 2017

Codecov Report

Merging #316 into master will decrease coverage by 69.52%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #316       +/-   ##
===========================================
- Coverage   96.48%   26.96%   -69.52%     
===========================================
  Files           8        8               
  Lines        1250     1250               
  Branches      245      245               
===========================================
- Hits         1206      337      -869     
- Misses         44      913      +869
Impacted Files Coverage Δ
lib/bucket.js 11.65% <0%> (-86.55%) ⬇️
lib/object.js 12.54% <0%> (-83.88%) ⬇️
lib/multipart.js 13.04% <0%> (-83.1%) ⬇️
lib/cluster.js 23.07% <0%> (-76.16%) ⬇️
lib/sts.js 28.37% <0%> (-66.22%) ⬇️
lib/wrapper.js 44.44% <0%> (-51.86%) ⬇️
lib/client.js 47.67% <0%> (-45.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 060df98...6472d42. Read the comment docs.

@@ -5,13 +5,15 @@
"main": "lib/client.js",
"files": [
"lib",
"shims"
"shims",
"dist"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist 目录发布到 npm,为什么呢?

Copy link
Collaborator Author

@PeterRao PeterRao Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有部分用户反馈,构建的时候不想用babel-loader什么的转,想直接引用进来。原始的里面有不少es6的语法。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好吧,dist 会有多大?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

未压缩是728K,压缩的是323K

@JacksonTian
Copy link
Contributor

我看了下,觉得 ok。

@fengmk2 fengmk2 merged commit 12a4271 into ali-sdk:master Dec 21, 2017
@fengmk2
Copy link
Member

fengmk2 commented Dec 21, 2017

4.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants