-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add shims for browser and change the sts expire time of example … #316
Conversation
PeterRao
commented
Nov 14, 2017
- add shims for browser
- change the default sts expire time fo the example project
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
===========================================
- Coverage 96.48% 26.96% -69.52%
===========================================
Files 8 8
Lines 1250 1250
Branches 245 245
===========================================
- Hits 1206 337 -869
- Misses 44 913 +869
Continue to review full report at Codecov.
|
@@ -5,13 +5,15 @@ | |||
"main": "lib/client.js", | |||
"files": [ | |||
"lib", | |||
"shims" | |||
"shims", | |||
"dist" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dist 目录发布到 npm,为什么呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有部分用户反馈,构建的时候不想用babel-loader什么的转,想直接引用进来。原始的里面有不少es6的语法。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好吧,dist 会有多大?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
未压缩是728K,压缩的是323K
我看了下,觉得 ok。 |
4.11.3 |