Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multipart copy support #371

Merged
merged 8 commits into from
Feb 26, 2018

Conversation

binghaiwang
Copy link
Contributor

@binghaiwang binghaiwang commented Feb 2, 2018

1.multipart copy support
2.add listPart, initMultipart, uploadPart, completeMultipart api

README.md Outdated

- name {String} object name
- uploadId {String} get by initMultipartUpload api
- partNo (Integer) range is 1-10000, If this range is exceeded, OSS returns the InvalidArgument's error code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

() 改成 {}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

README.md Outdated

- name {String} object name
- uploadId {String} get by initMultipartUpload api
- parts (Array)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

() 改成 {}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

README.md Outdated
```


### .multipartUpload*(name, file[, options])

Upload file with [OSS multipart][oss-multipart].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释下封装了哪些接口

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codecov-io
Copy link

codecov-io commented Feb 7, 2018

Codecov Report

Merging #371 into master will decrease coverage by 71.39%.
The diff coverage is 11.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   96.01%   24.61%   -71.4%     
==========================================
  Files           9       12       +3     
  Lines        1379     1552     +173     
  Branches      269      293      +24     
==========================================
- Hits         1324      382     -942     
- Misses         55     1170    +1115
Impacted Files Coverage Δ
lib/managed_upload.js 13.98% <0%> (ø)
lib/client.js 46.3% <100%> (-47.01%) ⬇️
lib/bucket.js 12.28% <40%> (-85.93%) ⬇️
lib/common/multipart-copy.js 8% <8%> (ø)
lib/common/multipart.js 9.75% <9.75%> (ø)
lib/object.js 12.54% <0%> (-83.88%) ⬇️
lib/rtmp.js 14.01% <0%> (-76.64%) ⬇️
lib/cluster.js 23.07% <0%> (-76.16%) ⬇️
lib/sts.js 28.37% <0%> (-66.22%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87f6da...a881b3a. Read the comment docs.

@PeterRao
Copy link
Collaborator

PeterRao commented Feb 7, 2018

uploadPart接口入参及文档不明确,需要重写

@PeterRao PeterRao merged commit e42a534 into ali-sdk:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants