Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should consume the response stream on error #506

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jul 19, 2018

backport from #503

@fengmk2 fengmk2 added the bug label Jul 19, 2018
@fengmk2 fengmk2 requested a review from dead-horse July 19, 2018 06:34
@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #506 into 4.x will decrease coverage by 0.98%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              4.x     #506      +/-   ##
==========================================
- Coverage   96.56%   95.58%   -0.99%     
==========================================
  Files          13       13              
  Lines        1574     1584      +10     
  Branches      299      303       +4     
==========================================
- Hits         1520     1514       -6     
- Misses         54       70      +16
Impacted Files Coverage Δ
lib/object.js 96.45% <ø> (-0.36%) ⬇️
lib/client.js 93.63% <100%> (+0.24%) ⬆️
lib/common/callback.js 25% <0%> (-75%) ⬇️
lib/common/multipart.js 97.61% <0%> (-1.2%) ⬇️
lib/common/multipart-copy.js 98.01% <0%> (-1%) ⬇️
lib/managed_upload.js 95.8% <0%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac52b7...29a6293. Read the comment docs.

@fengmk2 fengmk2 merged commit 464e5ac into 4.x Jul 19, 2018
@fengmk2 fengmk2 deleted the consume-error-stream branch July 19, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant