Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

feature: support updating block io limit #15

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

zjumoon01
Copy link

Support updating blkio read/write bps/iops.
throttleReadBpsDevice, throttleWriteBpsDevice, throttleReadIOPSDevice and throttleWriteIOPSDevice can be updated with this patch.

Signed-off-by: Wang Rui baijia.wr@antfin.com

@houstar
Copy link

houstar commented Dec 30, 2018

Could anyone review this PR? thanks

@allencloud
Copy link

Could anyone review this PR? thanks

I am afraid that the CI failed. Please help to take a look. @houstar @zjumoon01

I am wondering if the following result is related:

Makefile:84: recipe for target 'localrootlessintegration' failed
make: *** [localrootlessintegration] Error 1
make[1]: *** [rootlessintegration] Error 2
make[1]: Leaving directory `/home/travis/gopath/src/github.com/opencontainers/runc'
make: *** [test] Error 2
The command "make BUILDTAGS="${BUILDTAGS}" clean ci cross" exited with 2.

update.go Outdated Show resolved Hide resolved
update.go Outdated Show resolved Hide resolved
@zjumoon01
Copy link
Author

Could anyone review this PR? thanks

I am afraid that the CI failed. Please help to take a look. @houstar @zjumoon01

I am wondering if the following result is related:

Makefile:84: recipe for target 'localrootlessintegration' failed
make: *** [localrootlessintegration] Error 1
make[1]: *** [rootlessintegration] Error 2
make[1]: Leaving directory `/home/travis/gopath/src/github.com/opencontainers/runc'
make: *** [test] Error 2
The command "make BUILDTAGS="${BUILDTAGS}" clean ci cross" exited with 2.

I see the CI has been failed since commit cb0fd7d on branch develop due to the same error.
@Ace-Tang , could you please have a check together ?

@Ace-Tang
Copy link
Collaborator

Ace-Tang commented Jan 4, 2019

I fix the ci fail with develop branch, fail because PR #12, it get some extend cgroup interface, it can not work with runc v1.0.0-rc6.
This PR need rebase on new develop branch

support updating blkio read/write bps/iops.

Signed-off-by: Wang Rui <baijia.wr@antfin.com>
@Ace-Tang
Copy link
Collaborator

Ace-Tang commented Jan 7, 2019

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants