fix multi-process reading of detection datasource and accelerate data preprocessing #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cathy0908
changed the title
wenmengzhou
reviewed
Apr 25, 2022
| Args: | ||
| source_item: item of source iterator | ||
| classes: classes list | ||
| parse_fn: parse pn to parse source_item, only accepts two params: source_item and classes |
There was a problem hiding this comment.
modify to parse function, done!
wenmengzhou
reviewed
Apr 25, 2022
wenmengzhou
reviewed
Apr 25, 2022
|
|
||
| @abstractmethod | ||
| def get_source_iterator(): | ||
| """data list iterator, for multi-process read |
There was a problem hiding this comment.
more detailed docstr is missing, iterator of which kind format of data
wenmengzhou
reviewed
Apr 25, 2022
wenmengzhou
reviewed
Apr 25, 2022
| Args: | ||
| source_item: item of source iterator | ||
| classes: classes list | ||
| parse_fn: parse function to parse source_item, only accepts two params: source_item and classes |
There was a problem hiding this comment.
describe what kind of data should be returned, key_name, value_type
wenmengzhou
reviewed
Apr 25, 2022
| logging.warning( | ||
| 'Something wrong with current sample %s,Try load next sample...' | ||
| % result_dict.get('filename', '')) | ||
| result_dict = self.get_sample(idx + 1) |
There was a problem hiding this comment.
this recursive call may result in index out of bounds when dealing last exmaple with exception, it will try to get the len(data_source)th element
There was a problem hiding this comment.
done! and add _max_retry_num to avoid looping all the time
wenmengzhou
requested changes
Apr 25, 2022
wenmengzhou
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.