Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]: add mind neg sam #108

Merged
merged 35 commits into from
May 17, 2022
Merged

[feat]: add mind neg sam #108

merged 35 commits into from
May 17, 2022

Conversation

chengmengli06
Copy link
Collaborator

add negative sampling for mind.

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ chengmengli06
❌ 杨熙

杨熙 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

CI Test Failed

@github-actions
Copy link

CI Test Failed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot added ci_test_passed ci test passed and removed ci_test_failed labels Jan 14, 2022
@chengmengli06 chengmengli06 changed the title add mind neg sam [feature]: add mind neg sam Jan 19, 2022
@chengmengli06 chengmengli06 changed the title [feature]: add mind neg sam [feat]: add mind neg sam Jan 19, 2022
@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot added ci_test_passed ci test passed and removed ci_test_passed ci test passed labels May 16, 2022
@github-actions
Copy link

CI PY3 Test Passed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot added ci_test_passed ci test passed and removed ci_test_passed ci test passed labels May 16, 2022
@github-actions
Copy link

CI PY3 Test Passed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot added ci_test_passed ci test passed and removed ci_test_passed ci test passed labels May 17, 2022
@github-actions
Copy link

CI PY3 Test Passed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot added the ci_test_passed ci test passed label May 17, 2022
poson
poson approved these changes May 17, 2022
View reviewed changes
easy_rec/python/model/match_model.py

if self._loss_type in [LossType.CLASSIFICATION, LossType.L2_LOSS]:
self._is_point_wise = True
logging.info('Use point wise dssm.')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pairwise

easy_rec/python/model/match_model.py
logging.info('Use point wise dssm.')
else:
self._is_point_wise = False
logging.info('Use list wise dssm.')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listwise

@chengmengli06 chengmengli06 merged commit 4f92e64 into master May 17, 2022
@chengmengli06 chengmengli06 deleted the add_mind_neg_sam branch October 12, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poson poson poson approved these changes

Assignees
No one assigned
Labels
ci_py3_test_passed ci_test_passed ci test passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chengmengli06 @CLAassistant @poson