Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix slow node crush in hive predictor #220

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

dawn310826
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

CI PY3 Test Passed

@github-actions
Copy link

CI Test Passed

""".format(str_fields, self.task_num, self.task_index)
else:
sql += """
where {} and hash(concat({}))%{}={}
where {} and abs(hash(concat({})))%{}={}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where CAST(ROUND(rand() * self.task_num) AS BIGINT) = self.task_index

Copy link
Collaborator Author

@dawn310826 dawn310826 Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where CAST(rand(1) * self.task_num) AS BIGINT) = self.task_index
drop ROUND and add random seed

res_path = os.path.join(self._hdfs_path, 'SUCCESS-%s' % id)
if not gfile.Exists(res_path):
time.sleep(10)
self._check_worker_success(slice_num)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too much recursion

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions
Copy link

CI PY3 Test Passed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot added ci_test_passed ci test passed and removed ci_test_passed ci test passed labels Jun 21, 2022
Copy link
Collaborator

@tiankongdeguiji tiankongdeguiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiankongdeguiji tiankongdeguiji merged commit ccacb30 into master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci_test_passed ci test passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants