[Feat] Support hit rate on ds #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
CI Test Passed |
|
CI Test Passed |
github-actions
bot
added
ci_test_passed
|
CI PY3 Test Passed |
lgqfhwy
reviewed
Jul 18, 2022
| tf.train.replica_device_setter( | ||
| worker_device='/job:worker/task:%d' % task_index, cluster=cluster)): | ||
| with tf.variable_scope('hitrate_var', reuse=tf.AUTO_REUSE): | ||
| var_worker_count = tf.get_variable( |
There was a problem hiding this comment.
这些参数的变量是不是放在了各自的 worker 上，没有放在 ps 上
| outs = sess.run([var_total_hitrate, var_worker_count]) | ||
|
|
||
| # write after all workers have completed the calculation of hitrate. | ||
| if outs[1] == worker_count: |
There was a problem hiding this comment.
outs[0]是全局聚合后最终的hitrate，outs[1]是worker数
|
CI PY3 Test Passed |
lgqfhwy
approved these changes
Jul 19, 2022
|
CI PY3 Test Passed |
|
CI Test Failed |
github-actions
bot
added
ci_test_failed
and removed
ci_test_passed
|
CI Test Passed |
github-actions
bot
added
ci_test_passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.