Skip to content

Commit

Permalink
Fixes the misuse of "continue-on-error" and "fail_ci_if_error". (#2904)
Browse files Browse the repository at this point in the history
See also commit 612bd7f.

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
  • Loading branch information
sighingnow authored Jun 15, 2023
1 parent 612bd7f commit 0a44e71
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 6 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/gae.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ jobs:
- name: Upload Coverage
uses: codecov/codecov-action@v3
continue-on-error: true
with:
file: ./python/coverage.xml
continue-on-error: true
fail_ci_if_error: false
3 changes: 2 additions & 1 deletion .github/workflows/k8s-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -490,9 +490,10 @@ jobs:
- name: Upload Coverage
uses: codecov/codecov-action@v3
continue-on-error: true
with:
file: ./python/coverage.xml
continue-on-error: true
fail_ci_if_error: false

- name: HDFS test
env:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/local-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -380,9 +380,10 @@ jobs:
- name: Upload Coverage
if: ${{ needs.changes.outputs.gae-python == 'true' || github.ref == 'refs/heads/main' }}
uses: codecov/codecov-action@v3
continue-on-error: true
with:
file: ./coverage.xml
continue-on-error: true
fail_ci_if_error: false

networkx-basic-test:
runs-on: ubuntu-20.04
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/networkx-forward-algo-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
- name: Upload Coverage
uses: codecov/codecov-action@v3
continue-on-error: true
with:
file: ./python/coverage.xml
continue-on-error: true
fail_ci_if_error: false
3 changes: 2 additions & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ jobs:
- name: Upload Coverage
uses: codecov/codecov-action@v3
if: matrix.os == 'ubuntu-20.04'
continue-on-error: true
with:
file: ./python/coverage.xml
continue-on-error: true
fail_ci_if_error: false
2 changes: 1 addition & 1 deletion python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def build_learning_engine():
library_dirs.append(ROOT_PATH + "/graphlearn/built/lib")

extra_compile_args.append("-D__USE_XOPEN2K8")
extra_compile_args.append("-std=c++11")
extra_compile_args.append("-std=c++17")
extra_compile_args.append("-fvisibility=hidden")

libraries.append("graphlearn_shared")
Expand Down

0 comments on commit 0a44e71

Please sign in to comment.