Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIE Compiler] Fix query params of getV base in path expand operator #2773

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented May 30, 2023

What do these changes do?

In the cypher statement (a:person)-[b:knows]-(c:person) that represents a path expansion, the logical plan includes two getV operators. One is getV base inner the path_expand b, another is the endV operator following the b. It's important to note that these operators have different query parameters.

The getV base can retrieve vertices of any type that are adjacent to the type specified in the path_expand operation. This pr specifically addresses this requirement. The endV operator is constrained by the type specified in the given query.

Related issue number

Fixes

@shirly121 shirly121 requested review from longbinlai and lnfjpt May 30, 2023 07:32
@codecov-commenter
Copy link

Codecov Report

Merging #2773 (8bb4963) into main (99c9d15) will decrease coverage by 31.48%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2773       +/-   ##
===========================================
- Coverage   73.91%   42.44%   -31.48%     
===========================================
  Files          99       99               
  Lines       10665    10654       -11     
===========================================
- Hits         7883     4522     -3361     
- Misses       2782     6132     +3350     

see 57 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2334c...8bb4963. Read the comment docs.

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirly121 shirly121 merged commit ec218cf into alibaba:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants