[GIE Compiler] Unify execution client which is used to send request to remote engine service #2818
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2818 +/- ##
===========================================
- Coverage 73.91% 42.44% -31.48%
===========================================
Files 99 99
Lines 10665 10654 -11
===========================================
- Hits 7883 4522 -3361
- Misses 2782 6132 +3350 see 57 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
|
||
| message HighQPSQuery { | ||
| common.NameOrId query_name = 1; | ||
| repeated Argument arguments = 2; |
There was a problem hiding this comment.
Donot call them HighQPS xx. These are StoredProcedureQuery, StoredProcedureResults and StoredProcedureArgument. The name is also stored_procedure.proto
| @@ -112,7 +99,7 @@ public static void main(String[] args) throws Exception { | |||
| List<RpcChannel> channels = new ArrayList<>(); | |||
| channels.add(rpcChannel0); | |||
| channels.add(rpcChannel1); | |||
| RpcClient rpcClient = new RpcClient(channels); | |||
| RpcClient rpcClient = new RpcClient(600000, channels); | |||
There was a problem hiding this comment.
Can the RPC timeout be configured? What is the relation of this timeout with the Gremlin query timeout and Pegasus execution timeout?
There was a problem hiding this comment.
现在RpcClient的timeout都是从配置里读的，这个是测试文件，所以直接给了个值；配置https://github.com/alibaba/GraphScope/pull/2818/files#diff-6cfeda4b115b8cce14e597b6798de6b7ee897f0b6ac69d14a00dc1013796c639
和gremlin/pegasus timeout是独立的配置项目，理论上需要gremlin timeout > grpc timeout > pegasus timeout
|
|
||
| package com.alibaba.graphscope.common.config; | ||
|
|
||
| public class HQPSConfig { |
There was a problem hiding this comment.
Call this HiactorConfig. Correspondingly, the following configuration should start with HIACTOR_XX, and hiactor.xx.
|
|
||
| public class HQPSConfig { | ||
| public static final Config<String> HQPS_URIS = | ||
| Config.stringConfig("hqps.uris", "http://localhost:8080"); |
There was a problem hiding this comment.
Configure this as hosts: localhost:8080, just like Pegasus, and then we make it uris internally (this may change to grpc in the future, FYI. )
… into ir_execution_client
What do these changes do?
as titled.
Related issue number
Fixes