Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordinator as the Ownerreferces of frontend deployment. #2830

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

dashanji
Copy link
Collaborator

@dashanji dashanji commented Jun 7, 2023

What do these changes do?

As titled.

Related issue number

Fixes #2829

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji dashanji marked this pull request as draft June 7, 2023 11:07
@dashanji dashanji marked this pull request as ready for review June 7, 2023 11:13
@dashanji dashanji requested a review from siyuan0322 June 7, 2023 11:38
@codecov-commenter
Copy link

Codecov Report

Merging #2830 (3c9ecc4) into main (ec218cf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2830   +/-   ##
=======================================
  Coverage   42.44%   42.44%           
=======================================
  Files          99       99           
  Lines       10654    10654           
=======================================
  Hits         4522     4522           
  Misses       6132     6132           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec218cf...3c9ecc4. Read the comment docs.

@sighingnow sighingnow merged commit d75ba7b into alibaba:main Jun 7, 2023
@dashanji dashanji deleted the fix-frontend-pod-not-exit branch June 8, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Frontend pod will not be deleted by coordinator when coordinator crashs.
4 participants