Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIE Compiler] Introduce GraphPlanner to unify logical and physical plan building #2838

Merged
merged 8 commits into from
Jun 8, 2023

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Jun 8, 2023

What do these changes do?

  1. re-design PhysicalBuilder to build physical plan from logical plan, FfiPhysicalBuilder is one of the implementations which will build physical plan in ir core structure
  2. introduce GraphPlanner to unify logical and physical plan building phases
  3. other minor fix: refine the structure of IrMeta which contains schema info

Related issue number

Fixes

@shirly121 shirly121 requested a review from longbinlai June 8, 2023 06:40
@codecov-commenter
Copy link

Codecov Report

Merging #2838 (202a22f) into main (f469415) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2838   +/-   ##
=======================================
  Coverage   42.44%   42.44%           
=======================================
  Files          99       99           
  Lines       10654    10654           
=======================================
  Hits         4522     4522           
  Misses       6132     6132           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e45e0...202a22f. Read the comment docs.

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I� will approve for now.

@longbinlai longbinlai merged commit 1ba6102 into alibaba:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants