Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the inconsistent usage of msgpack/json in graph reporter #2843

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

sighingnow
Copy link
Collaborator

Related issue number

Fixes #2823.

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Merging #2843 (1e423ee) into main (1ba6102) will increase coverage by 0.14%.
The diff coverage is 88.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2843      +/-   ##
==========================================
+ Coverage   42.44%   42.59%   +0.14%     
==========================================
  Files          99       99              
  Lines       10654    10657       +3     
==========================================
+ Hits         4522     4539      +17     
+ Misses       6132     6118      -14     
Impacted Files Coverage Δ
python/graphscope/client/session.py 66.77% <66.66%> (+0.16%) ⬆️
python/graphscope/framework/app.py 70.77% <100.00%> (+0.91%) ⬆️
python/graphscope/framework/context.py 45.19% <100.00%> (+0.56%) ⬆️
python/graphscope/framework/graph.py 69.71% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba6102...1e423ee. Read the comment docs.

@siyuan0322
Copy link
Collaborator

:trollface:

@sighingnow sighingnow force-pushed the ht/fix-msgpack branch 2 times, most recently from d8f1aef to 1e423ee Compare June 9, 2023 11:46
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow merged commit 5fd6cc1 into alibaba:main Jun 9, 2023
@sighingnow sighingnow deleted the ht/fix-msgpack branch June 9, 2023 13:11
sighingnow added a commit that referenced this pull request Jun 14, 2023
#2888)

The issue was first introduced in #2843.

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] networkx tests failed with crash
3 participants