Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct the content of log files to stdout of pods in kubernetes deployment #2871

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

siyuan0322
Copy link
Collaborator

What do these changes do?

Related issue number

Fixes #2357

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

🎊 PR Preview 3c30b06 has been successfully built and deployed to https://alibaba-graphscope-build-pr-2871.surge.sh

🤖 By surge-preview

@siyuan0322 siyuan0322 requested a review from sighingnow June 13, 2023 04:15
@codecov-commenter
Copy link

Codecov Report

Merging #2871 (0d95307) into main (434acdf) will increase coverage by 23.71%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2871       +/-   ##
===========================================
+ Coverage   42.44%   66.16%   +23.71%     
===========================================
  Files          99       99               
  Lines       10654    10657        +3     
===========================================
+ Hits         4522     7051     +2529     
+ Misses       6132     3606     -2526     
Impacted Files Coverage Δ
python/graphscope/client/session.py 66.93% <100.00%> (+0.32%) ⬆️
python/graphscope/framework/app.py 90.41% <100.00%> (+20.54%) ⬆️
python/graphscope/framework/context.py 66.38% <100.00%> (+21.75%) ⬆️
python/graphscope/framework/graph.py 83.92% <100.00%> (+14.20%) ⬆️

... and 56 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b36ee...0d95307. Read the comment docs.

@siyuan0322 siyuan0322 merged commit 559b084 into alibaba:main Jun 13, 2023
@siyuan0322 siyuan0322 deleted the zsy/log branch June 13, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direct log file to stdout for engines in Kubernetes deployment
3 participants