Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pass params to gie instance #2885

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

siyuan0322
Copy link
Collaborator

@siyuan0322 siyuan0322 commented Jun 14, 2023

Allow passing a dict to customize the configuration of GIE instance.

interactive = graphscope.gremlin(graph, params={'pegasus.timeout': 600000})

The key-value pair would be append to the vineyard.frontend.properties and vineyard.executor.properties.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

🎊 PR Preview 7a5023f has been successfully built and deployed to https://alibaba-graphscope-build-pr-2885.surge.sh

🤖 By surge-preview

@longbinlai
Copy link
Collaborator

Can we call the name "query.timeout" instead of "pegasus.timeout" ?

@siyuan0322
Copy link
Collaborator Author

Can we call the name "query.timeout" instead of "pegasus.timeout" ?

So, all that is needed is to replace the text 'pegasus.timeout' with 'query.timeout' throughout the code base, or is more work required from @shirly121 ?

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #2885 (7a5023f) into main (4af5689) will increase coverage by 30.74%.
The diff coverage is 62.50%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2885       +/-   ##
===========================================
+ Coverage   42.59%   73.33%   +30.74%     
===========================================
  Files          99       99               
  Lines       10657    10670       +13     
===========================================
+ Hits         4539     7825     +3286     
+ Misses       6118     2845     -3273     
Impacted Files Coverage Δ
python/graphscope/client/rpc.py 82.48% <50.00%> (+2.63%) ⬆️
python/graphscope/client/session.py 76.17% <75.00%> (+9.40%) ⬆️

... and 53 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a63faf...7a5023f. Read the comment docs.

@siyuan0322
Copy link
Collaborator Author

Merged, we could leave the renaming to the unify the timeout PR.

@siyuan0322 siyuan0322 merged commit e4f1f23 into alibaba:main Jun 14, 2023
@siyuan0322 siyuan0322 deleted the zsy/gie-param branch June 14, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants