fix(interactive): Fix bug in ExpandGetVFusionRule, and optimize when GetV has imprecise types
#3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h does not need type filering anymore
longbinlai
approved these changes
May 17, 2024
shirly121
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As titled. This pr:
ExpandGetVFusionRule. For example, assume we have edge types ofperson-likes-comment,person-likes-post,person-knows-personin schema. Then in queries, if we want to expandperson-likes-comment, we would generate aExpand(likes)+GetV(comment)(before this fix, we generate aExpand(likes)only, which is a bug); And if we want to expandperson-knows-person, we simply generate aExpand(knows).Related issue number
Fixes #3732 #3802