Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Allow implicit type conversion in WithInExpr #4514

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

zhanglei1949
Copy link
Collaborator

As titled.

Fix #4513

Committed-by: xiaolei.zl from Dev container
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Please check the preview of the documentation changes at
https://b8091d0e.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.01%. Comparing base (5d6d660) to head (24c0748).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4514   +/-   ##
=======================================
  Coverage   35.01%   35.01%           
=======================================
  Files         127      127           
  Lines       13299    13299           
=======================================
  Hits         4657     4657           
  Misses       8642     8642           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d6d660...24c0748. Read the comment docs.

@zhanglei1949 zhanglei1949 changed the title fix(interactive): Allow basic implicit type conversion in WithInExpr fix(interactive): Allow implicit type conversion in WithInExpr Feb 21, 2025
Committed-by: xiaolei.zl from Dev container
Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for now. We will need a more generic solution for implicit type conversion.

@zhanglei1949 zhanglei1949 merged commit 49520e4 into alibaba:main Feb 24, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No result when running cypher query
4 participants