FEATURE: optmize bash execution by pty #104
Conversation
…t of dependency on global locks.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b20500ddb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cleanCmd := strings.ReplaceAll(command, "\n", " ; ") | ||
|
|
||
| // send command + marker, preserving the user's last exit code | ||
| // use a subshell at the end to restore $? to the original exit code | ||
| cmdText := fmt.Sprintf("%s\n__c=$?\nprintf \"%s${__c}%s\\n\"\n(exit ${__c})\n", cleanCmd, exitCodePrefix, exitCodeSuffix) |
There was a problem hiding this comment.
Before executing a bash command, run replaces every newline with ;. This changes shell semantics and breaks newline-sensitive constructs such as here-docs (cat <<'EOF' ... EOF) or multi-line case/read blocks, which now become syntax errors. Since the API accepts multi-line code strings, this is a regression for valid bash scripts. Consider sending the original string (or another framing mechanism that preserves newlines) instead of flattening them.
Useful? React with 👍 / 👎.
3 participants
Summary
Testing
Breaking Changes
Checklist