feature: add agent-sandbox kubernetes provider #126
Conversation
jwx0925
requested review from
Generalwin,
Pangjiping,
hittyt and
ninan-nn
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jwx0925
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 667ff222db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for pod in pods: | ||
| if pod.status and pod.status.pod_ip and pod.status.phase == "Running": | ||
| return f"{pod.status.pod_ip}:{port}" |
There was a problem hiding this comment.
The endpoint resolver returns the first Running pod IP before considering status.serviceFQDN. In environments where the API server or clients are outside the cluster (or rely on ingress), pod IPs are not routable, so this returns an unusable endpoint even when a serviceFQDN is available. This makes get_endpoint fail for agent-sandbox deployments that expect ingress/service DNS. Consider preferring the serviceFQDN when present (or when ingress is enabled) to avoid returning unreachable pod IPs.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
It's supported now. Implement soon.
jwx0925
changed the title
jwx0925
changed the title
There was a problem hiding this comment.
This template loader looks like a copy of batchsandbox_template—can we find a way to reuse this part?
Summary
Testing