reimplement crc64ecma_sw to reduce redundancy #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuiba
force-pushed
the
reimplement_crc64ecma
branch
2 times, most recently
from
ba237b4 to
645d0c3
Compare
Coldwings
reviewed
Jan 17, 2025
common/checksum/crc.cpp
Outdated
| @@ -767,407 +762,54 @@ uint64_t crc64ecma_hw(const uint8_t *buf, size_t len, uint64_t crc) { | |||
| return crc64ecma_hw_portable(buf, len, crc); | |||
| } | |||
|
|
|||
| template<typename T, T POLY> | |||
There was a problem hiding this comment.
The table is able to create in compile-time, by using template.
why create it in runtime?
There was a problem hiding this comment.
that is rarely used today, given that crc hw is common.
There was a problem hiding this comment.
it's a waste in both compile time and binary size to generate the table in compile-time.
lihuiba
force-pushed
the
reimplement_crc64ecma
branch
3 times, most recently
from
2549b7c to
63f61eb
Compare
lihuiba
force-pushed
the
reimplement_crc64ecma
branch
from
63f61eb to
fed9e9d
Compare
and make the table generated dynamically at runtime, so as to reduce redundant static data that is rarely today, given that crc hw is common.
lihuiba
force-pushed
the
reimplement_crc64ecma
branch
from
fed9e9d to
cd591b3
Compare
Coldwings
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement crc64ecma_sw to reduce redundant code, by unifying crc32 and crc64.
And make the table generated dynamically at runtime, so as to reduce redundant static data that is rarely used today, given that crc hw is common.