remove statInterval check when adding degrade rules #1848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brotherlu-xcq
added a commit
to brotherlu-xcq/Sentinel
that referenced
this pull request
Jan 5, 2021
…com/brothelul/Sentinel into feature-alibaba#1848 � Conflicts: � sentinel-core/src/main/java/com/alibaba/csp/sentinel/slots/block/flow/FlowRuleManager.java
brotherlu-xcq
added a commit
to brotherlu-xcq/Sentinel
that referenced
this pull request
Jul 1, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/Sentinel
that referenced
this pull request
Sep 8, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/Sentinel
that referenced
this pull request
Sep 8, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/Sentinel
that referenced
this pull request
Sep 8, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/Sentinel
that referenced
this pull request
Sep 8, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/Sentinel
that referenced
this pull request
Sep 9, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/Sentinel
that referenced
this pull request
Sep 9, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/Sentinel
that referenced
this pull request
Sep 13, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/Sentinel
that referenced
this pull request
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
add_degrade_rule_error
Does this pull request fix one issue?
Describe how you did it
when add a new degrade rule at sentinel-dashboard , the js and controller has checkRuleValid at statIntervalMs ,but the attribute do not has this value, so remove statIntervalMs validate
Describe how to verify it
add new degrade rule success
Special notes for reviews