Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #1818] remove statInterval check when add degrade rules #1849

Closed
wants to merge 1 commit into from
Closed

[Fixes #1818] remove statInterval check when add degrade rules #1849

wants to merge 1 commit into from

Conversation

xipfs
Copy link

@xipfs xipfs commented Nov 12, 2020

Describe what this PR does / why we need it

add_degrade_rule_error

when add a new degrade rule at sentinel-dashboard , the js and controller has checkRuleValid at statIntervalMs ,but the attribute do not has this value, so remove statIntervalMs validate

Does this pull request fix one issue?

fix the issue #1818

Describe how you did it

remove statInterval check when add degrade rules

Describe how to verify it

add new degrade rule success

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2020

CLA assistant check
All committers have signed the CLA.

@xipfs xipfs changed the title remove statInterval check when add degrade rules [Fixes #1818] remove statInterval check when add degrade rules Nov 13, 2020
@sczyh30
Copy link
Member

sczyh30 commented Nov 16, 2020

Thanks for contributing. Perhaps this could be fixed by #1781

@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label Nov 16, 2020
@sczyh30 sczyh30 closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants