Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced ExceptionCircuitBreaker robustness #3285

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enhanced ExceptionCircuitBreaker robustness #3285

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f7e113
Enhanced robustness
CLFutureX Dec 1, 2023
fe8650f
modifu
CLFutureX Dec 10, 2023
3bb5877
modify
CLFutureX Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../com/alibaba/csp/sentinel/slots/block/degrade/circuitbreaker/ExceptionCircuitBreaker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,13 @@ public ExceptionCircuitBreaker(DegradeRule rule) {
ExceptionCircuitBreaker(DegradeRule rule, LeapArray<SimpleErrorCounter> stat) {
super(rule);
this.strategy = rule.getGrade();
this.threshold = rule.getCount();
boolean modeOk = strategy == DEGRADE_GRADE_EXCEPTION_RATIO || strategy == DEGRADE_GRADE_EXCEPTION_COUNT;
AssertUtil.isTrue(modeOk, "rule strategy should be error-ratio or error-count");
AssertUtil.isTrue(strategy == DEGRADE_GRADE_EXCEPTION_RATIO ? this.threshold <= 1.0 : this.threshold >= 1.0,
"threshold should be adjusted");
AssertUtil.notNull(stat, "stat cannot be null");
this.minRequestAmount = rule.getMinRequestAmount();
this.threshold = rule.getCount();
this.stat = stat;
}

Expand Down