-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #3386 #3395
fix #3386 #3395
Conversation
这看起来确实是个问题,但是要不要在运行时支持这种同名我觉得可能得再讨论下,因为这样做会引入一些不必要的额外的复杂度,但其实只要不重名就不会有问题,另外 Issue 中的这个插件看起来是个不错的解决方案 |
从概率论上讲,代码里出现重名导致这个bug是一定会出现的。所以要讨论的是怎么处理这个bug。 P.S. 欢迎试用插件。如果觉得不错,可以留言评论+分享。插件已设置开源项目 free 🤝。 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.8 #3395 +/- ##
============================================
- Coverage 45.90% 45.85% -0.06%
Complexity 2148 2148
============================================
Files 431 431
Lines 12906 12932 +26
Branches 1728 1728
============================================
+ Hits 5925 5930 +5
- Misses 6281 6301 +20
- Partials 700 701 +1
☔ View full report in Codecov by Sentry. |
如果方便的话,麻烦在sentinel-demo-annotation-spring-aop模块中完善下Demo以体现新的特性 |
OK,我这两天看时间搞下。 |
Run module sentinel-demo-annotation-spring-aop, and run following requests (in curl format) to verify that fallbacks won't overlap each other. Once the module started, you can call requests in any sequence. curl -XGET localhost:19966/bar?t= curl -XGET localhost:19966/foo?t=-1
Done. Run module curl -XGET localhost:19966/bar?t=
curl -XGET localhost:19966/foo?t=-1 |
另外昨天还看了下 resilience4j 的做法。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
感谢贡献🚀,欢迎后续进行进一步优化 |
Describe what this PR does / why we need it
This PR contains fixes for #3386
Does this pull request fix one issue?
Fixes #3386
Describe how you did it
Combine origin method's parameter type canonical names into register map key.
Describe how to verify it
See bug #3386 to repreduce and verify.
Special notes for reviews