Fix potential github action smells #3402

ceddy4395 · 2024-05-24T12:11:09Z

Hey! 🙂
I've made the following changes to your workflow:

Avoid installing packages without version
- When installing a package without a version, the latest version will always be installed, even when braking changes have been released. To avoid this causing failing pipelines a version should be specified which is known to be compatible with the code base.
Run tests on multiple OS's
- Testing on different OS's makes sure that they are currently and in the future supported when new changes are added to the code base.
Avoid workflows without comments
- Workflows can be used as a form of documentation, and therefore it helps if everything is clearly explained. This especially holds for when a workflow failed and a developer is trying to figure out what and why it failed.

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

CLAassistant · 2024-05-24T12:11:15Z

All committers have signed the CLA.

- Use fixed version for runs-on argument - Run tests on multiple OS's - Avoid workflows without comments

ceddy4395 force-pushed the fix-gha-smells branch from 7564662 to 1b8fb56 Compare May 24, 2024 14:01

Fix gha smells:

665d2da

- Use fixed version for runs-on argument - Run tests on multiple OS's - Avoid workflows without comments

ceddy4395 force-pushed the fix-gha-smells branch 3 times, most recently from ca7b3a1 to e61b86b Compare May 28, 2024 15:09

Put lifecycle phase at end of mvn command to test for windows

4128538

ceddy4395 force-pushed the fix-gha-smells branch from e61b86b to 4128538 Compare May 28, 2024 15:11

Provide feedback