Fix #3397 . #3415
Open
Fix #3397 . #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An spring-aop example that fits alibaba#3397 case is also provided: Run module sentinel-demo-annotation-spring-aop, and run following requests (in curl format) to verify that handlers won't conflict with each other. Once the module started, you can call requests in any sequence. curl -XGET localhost:19966/bar?t= curl -XGET localhost:19966/foo?t=-1 curl -XGET localhost:19966/count
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.8 #3415 +/- ##
============================================
+ Coverage 45.85% 45.88% +0.02%
- Complexity 2148 2151 +3
============================================
Files 431 432 +1
Lines 12932 12972 +40
Branches 1728 1733 +5
============================================
+ Hits 5930 5952 +22
- Misses 6301 6316 +15
- Partials 701 704 +3
☔ View full report in Codecov by Sentry. |
LearningGp
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This PR try to fix #3397
Does this pull request fix one issue?
Yes, #3397
Describe how you did it
Like the solution that fix #3386, the issue is caused by trying locate method with incomplete signature. So I rewrite the register map, with a key type that holds all method signature parts.
Describe how to verify it
Unit tests are provided and passed.
Also, an spring-aop example that fits #3397 case is also provided:
Run module sentinel-demo-annotation-spring-aop, and run following requests (in curl format) to verify that handlers won't conflict with each other. Once the module started, you can call requests in any sequence.
curl -XGET localhost:19966/bar?t=
curl -XGET localhost:19966/foo?t=-1
curl -XGET localhost:19966/count
Special notes for reviews